Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user-canceling of KDE Wallet dialogs causes unhandled exception #37

Closed
jaraco opened this issue Feb 24, 2015 · 1 comment
Closed

user-canceling of KDE Wallet dialogs causes unhandled exception #37

jaraco opened this issue Feb 24, 2015 · 1 comment

Comments

@jaraco
Copy link
Owner

jaraco commented Feb 24, 2015

Upon import of kwallet.backends (which is done upon import of kwallet), the KDE Wallet modules are imported and if the import succeeds the wallet is opened.

Opening the wallet will sometimes (if the wallet hasn't been opened in this session) request a password to unlock the wallet or (if the user hasn't granted perminant access to this application) ask if the application is allowed to access the wallet.

If the user declines either of these dialogs an exception will be raised because kwallet is None and a method call is attempted on it.

I've attached a fix for this problem, with tests.
@jaraco jaraco closed this as completed Feb 24, 2015
@jaraco
Copy link
Owner Author

jaraco commented Feb 24, 2015

The proposed fix has been applied (changeset 8ab34d64325f).

Original comment by: Benji York

jaraco added a commit that referenced this issue Jan 9, 2021
@webknjaz @jaraco
Replace pep517.build with build (#37)
1731fbe 
* Replace pep517.build with build

Resolves #30

* Prefer simple usage

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
jaraco added a commit that referenced this issue Jan 9, 2021
@webknjaz @jaraco
Use extend-ignore in flake8 config (#33)
77fbe1d 
* Use `extend-ignore` in flake8 config

This option allows to add extra ignored rules to the default list
instead of replacing it.

The default exclusions are: E121, E123, E126, E226, E24, E704,
W503 and W504.

Fixes #28.

Refs:
* https://github.com/pypa/setuptools/pull/2486/files#r541943356
* https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-extend-ignore
*
https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-ignore

* Enable complexity limit. Fixes jaraco/skeleton#34.

* Replace pep517.build with build (#37)

* Replace pep517.build with build

Resolves #30

* Prefer simple usage

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

* Use license_files instead of license_file in meta (#35)

Singular `license_file` is deprecated since wheel v0.32.0.

Refs:
* https://wheel.readthedocs.io/en/stable/news.html
* https://wheel.readthedocs.io/en/stable/user_guide.html#including-license-files-in-the-generated-wheel-file

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaraco