Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for abode light_bulb type device #24

Open
darrick opened this issue Jan 3, 2024 · 1 comment
Open

Add support for abode light_bulb type device #24

darrick opened this issue Jan 3, 2024 · 1 comment
Assignees

Comments

@darrick
Copy link

darrick commented Jan 3, 2024

I'm using Home Assistant so needed to make this work for v3.3.0. And I'm not sure if it's possible to create a PR for a tag.

I also don't understand how your test framework works. I'm a bit new to python.

Below works on my end. The control_url didn't work for set_status or set_level but the integrations/v1 url did. I mostly just used the firefox debugger to see what the goabode dashboard was doing and copied that. I believe what may need some fixing is the self.update(response_object) call in the set_level function. As when the bulb is off and you set_level the status change isn't reflected in home assistant.

I can do a PR to to main after testing with the abode cli if you'd like.

And if anyone else stumbles across this I enabled it by copying the core abode component to /custom_components/abode and then in the manifest.json added a version and changed jaraco.abode requirement to point to my fork:

"version": "0.1.0",
"requirements": ["git+https://github.com/darrick/jaraco.abode.git@abode_light_bulb#jaraco.abode==0.2.2", "jaraco.functools==3.9.0"]

https://github.com/jaraco/jaraco.abode/compare/v3.3.0...darrick:abode_light_bulb?expand=1

@jaraco
Copy link
Owner

jaraco commented Feb 20, 2024

I also don't understand how your test framework works. I'm a bit new to python.

Fair. The guidance is hidden behind the "skeleton" badge in the readme, which links here. That doc describes how to run tests. Basically, have tox installed then run tox. Some recent systemic changes mean the tests are currently failing. I'll get that fixed promptly.

I can do a PR to to main after testing with the abode cli if you'd like.

I'll grab your code and get one started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants