Regression[3.0.2]: partials not working as intended after upgrading to version 3.0.2

[wol-soft]

Hi,

after upgrading to mustache.js 3.0.2 a component of my application failed to render a template which uses partials.

I copied the affected parts of the application into a JSFiddle (https://jsfiddle.net/z1jq2pu5/13/) to reproduce the error. The current result of the fiddle looks like:

With version 3.0.1 it looked like (can be reproduced by simply changing the CDN URL which includes mustache.js into the JSFiddle):

My application breaks with a message (which I can't reproduce in the JSFiddle somehow), may be helpful:

Error: Unclosed tag at 21
    at parseTemplate (VM448557 beerplop-game-1.59.3.min.js:17)
    at Writer.parse (VM448557 beerplop-game-1.59.3.min.js:17)
    at Writer.render (VM448557 beerplop-game-1.59.3.min.js:17)
    at subRender (VM448557 beerplop-game-1.59.3.min.js:17)
    at Object.<anonymous> (VM448557 beerplop-game-1.59.3.min.js:2810)
    at Writer.renderSection (VM448557 beerplop-game-1.59.3.min.js:17)
    at Writer.renderTokens (VM448557 beerplop-game-1.59.3.min.js:17)
    at Writer.renderPartial (VM448557 beerplop-game-1.59.3.min.js:17)
    at Writer.renderTokens (VM448557 beerplop-game-1.59.3.min.js:17)
    at Writer.render (VM448557 beerplop-game-1.59.3.min.js:17)

Seems like the tags of the partial aren't parsed correctly

[phillipj]

Thanks a lot for reporting! 👍At first glance, this sounds like something we should be able to reproduce in a unit test, both for the sake of fixing it ASAP and to ensure it doesn't happen again later.

[wol-soft]

Hi @phillipj, the values passed to functions are shifted by the indentation of the partial, see the tests from #713

[phillipj]

For future reference, this regression got introduced by #705

[phillipj]

v3.0.3 just got published to npm with a fix for this regression.

Thank you so much for your contributions! Both for reporting it and the added test cases were especially valuable! 💯

[wol-soft]

I can confirm the fix works.