Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli-test: fs.unlink → fs.unlinkSync to fix test failure on Node 10 #701

Merged
merged 1 commit into from Jun 26, 2019

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Jun 19, 2019

Fixes this failure:

  1) Mustache CLI without partials writes rendered template into the file specified by the third argument:
     Uncaught TypeError [ERR_INVALID_CALLBACK]: Callback must be a function
      at makeCallback (fs.js:136:11)
      at Object.unlink (fs.js:943:14)
      at test/cli-test.js:86:12
      at ChildProcess.exithandler (child_process.js:285:7)
      at maybeClose (internal/child_process.js:982:16)
      at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5)

Fixes this failure:

      1) Mustache CLI without partials writes rendered template into the file specified by the third argument:
         Uncaught TypeError [ERR_INVALID_CALLBACK]: Callback must be a function
          at makeCallback (fs.js:136:11)
          at Object.unlink (fs.js:943:14)
          at test/cli-test.js:86:12
          at ChildProcess.exithandler (child_process.js:285:7)
          at maybeClose (internal/child_process.js:982:16)
          at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5)

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@phillipj
Copy link
Collaborator

Thanks a lot for your contribution! 👍

Verified this indeed is an issue for Node.js 10 & 12 with this Travis CI build: https://travis-ci.org/janl/mustache.js/builds/550977559.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants