Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadows dissapear after some distance #49

Closed
janhohenheim opened this issue Jan 17, 2023 · 2 comments · Fixed by #228
Closed

Shadows dissapear after some distance #49

janhohenheim opened this issue Jan 17, 2023 · 2 comments · Fixed by #228
Labels
blocked Blocked by external work bug Something isn't working

Comments

@janhohenheim
Copy link
Owner

janhohenheim commented Jan 17, 2023

See bevyengine/bevy#5789
Looks like we have to move the projection with the player / the camera (careful, don't inherit the camera's rotation!) or switch to a point light for the sunlight. Using multiple directional lights / one per object stacks the light and causes weirdness, don't try that.

@janhohenheim janhohenheim added the bug Something isn't working label Jan 17, 2023
@janhohenheim
Copy link
Owner Author

janhohenheim commented Jan 20, 2023

Looks like a native solution is on its way: bevyengine/bevy#7064
Update: merged, waiting for Bevy v0.10
Looking forward to the builder (bevyengine/bevy#7456)!

Update: now only blocked by #159

@janhohenheim janhohenheim added the blocked Blocked by external work label Jan 20, 2023
@danchia
Copy link

danchia commented Jan 21, 2023

Yes! Cascaded shadow maps should avoid the need to keep moving the shadow projection. You may still want to customize the maximum shadow distance, but that's relative to the viewing camera now, instead of some absolute volume.

@janhohenheim janhohenheim added this to the Smooth Feeling milestone Feb 4, 2023
@janhohenheim janhohenheim mentioned this issue Mar 14, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by external work bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants