Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad download link for specific versions #11

Closed
airadier opened this issue Nov 5, 2020 · 1 comment
Closed

Bad download link for specific versions #11

airadier opened this issue Nov 5, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@airadier
Copy link

airadier commented Nov 5, 2020

When a gcov2lcov version is specified (i.e. v1.0.4), the download link is created as:

https://github.com/jandelgado/gcov2lcov/releases/v1.0.4/download/gcov2lcov-linux-amd64.tar.gz

But it should be:

https://github.com/jandelgado/gcov2lcov/releases/download/v1.0.4/gcov2lcov-linux-amd64.tar.gz

It seems that for latest, it works as:

https://github.com/jandelgado/gcov2lcov/releases/latest/download/gcov2lcov-linux-amd64.tar.gz

But not for specific versions.

jandelgado added a commit that referenced this issue Nov 5, 2020
@jandelgado jandelgado added the bug Something isn't working label Nov 5, 2020
jandelgado added a commit that referenced this issue Nov 5, 2020
when a specific gcov2lcov version is set.
@jandelgado
Copy link
Owner

jandelgado commented Nov 5, 2020

indeed, this is a bug and the download links are not constructed consistently. I fixed it, it should work now. @airadier, You can try it by testing the action with the commit-hash:

    - name: Convert coverage.out to coverage.lcov
      uses: jandelgado/gcov2lcov-action@f39cf324554c178f3fd58cb2a7414e48a9181a48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants