Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SCRIPT EXISTS and SCRIPT FLUSH subcommands #281

Merged

Conversation

SebastiaanZ
Copy link
Contributor

I've added support for SCRIPT EXISTS and SCRIPT FLUSH and wrote tests for the new features. If there's anything you'd like to see changed, I'd be happy to implement those changes.

I've added support for the SCRIPT EXISTS subcommand in the SCRIPTS
command handler. The subcommand takes in a sequence of sha1 hash values
of Lua scripts and checks if scripts with those sha1 hash values are
currently registered with Redis.

The command will return a redis List with the integers 1 and 0 to
indicate which sha1 hash is known to Redis. In accordance with Redis,
this subcommand returns an empty List if no hash values were passed as
arguments to the subcommand.
This commit adds support for the SCRIPT FLUSH subcommand which flushes
all the loaded scripts from Redis. The subcommand takes no arguments and
returns OK after completing its work.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 96.085% when pulling 6ca031c on SebastiaanZ:sebastiaanz/feat/script-subcommands into aaaad4b on jamesls:master.

Copy link
Collaborator

@bmerry bmerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like good work.

@bmerry bmerry merged commit dcf0c89 into jamesls:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants