Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set PHP's auto_globals_jit=0 #115

Closed
dkarlovi opened this issue Feb 7, 2019 · 8 comments
Closed

Explicitly set PHP's auto_globals_jit=0 #115

dkarlovi opened this issue Feb 7, 2019 · 8 comments

Comments

@dkarlovi
Copy link
Contributor

dkarlovi commented Feb 7, 2019

If set to auto_globals_jit=1, it breaks PHPUnit when running through phpdbg, sebastianbergmann/phpunit#3514

See http://php.net/manual/en/ini.core.php#ini.auto-globals-jit

@dkarlovi
Copy link
Contributor Author

dkarlovi commented Feb 7, 2019

I've had to add it manually (and first to find the issue, of course 🙈 ) so having it already be in the image makes sense to me.

@jakzal
Copy link
Owner

jakzal commented Feb 7, 2019

this is... weird :)

I'd try to avoid setting auto_globals_jit if possible.

@jakzal
Copy link
Owner

jakzal commented Feb 7, 2019

Is this only in alpine? see sebastianbergmann/phpunit#3352 (comment)

@dkarlovi
Copy link
Contributor Author

dkarlovi commented Feb 7, 2019

Maybe the setting is different in Alpine and Debian? Maybe it's a bug in upstream Docker image we inherit?

@dkarlovi
Copy link
Contributor Author

dkarlovi commented Feb 7, 2019

BTW since the image is meant for one-off CLI usage, I'd say we could still ensure this is disabled since the performance impact should be negligible (if any), but the tools being broken isn't.

@jakzal
Copy link
Owner

jakzal commented Feb 7, 2019

Sure. I only would like to see if there's no other way to solve the problem.

@dkarlovi
Copy link
Contributor Author

dkarlovi commented Feb 7, 2019

It's a PHPUnit issue, they don't seem interested in fixing it. Nice. 👍

@dkarlovi
Copy link
Contributor Author

dkarlovi commented Feb 7, 2019

Since it's being closed in both PHPUnit 7 & 8, closing here. Thanks for your voice in those issues. 👍

@dkarlovi dkarlovi closed this as completed Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants