Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting #518

Merged
merged 6 commits into from Jun 9, 2022
Merged

Fix linting #518

merged 6 commits into from Jun 9, 2022

Conversation

davidgoli
Copy link
Collaborator

My previous PR to migrate to eslint #514 didn't actually work correctly, and nothing was getting linted. This properly enables linting and reconciles conflicts between eslint and prettier.

@codecov-commenter
Copy link

Codecov Report

Merging #518 (9336e4b) into master (f066c4e) will increase coverage by 0.12%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
+ Coverage   88.61%   88.73%   +0.12%     
==========================================
  Files          30       29       -1     
  Lines        2029     2024       -5     
  Branches      753      754       +1     
==========================================
- Hits         1798     1796       -2     
+ Misses        231      228       -3     
Impacted Files Coverage Δ
.eslintrc.js 0.00% <ø> (ø)
src/dateutil.ts 96.87% <ø> (ø)
src/index.ts 100.00% <ø> (ø)
src/nlp/index.ts 100.00% <ø> (ø)
src/parsestring.ts 94.89% <ø> (ø)
src/nlp/parsetext.ts 52.92% <73.68%> (-0.17%) ⬇️
src/nlp/totext.ts 94.00% <93.93%> (-0.03%) ⬇️
src/cache.ts 92.98% <100.00%> (ø)
src/datetime.ts 90.00% <100.00%> (ø)
src/helpers.ts 96.36% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f066c4e...9336e4b. Read the comment docs.

@davidgoli davidgoli merged commit d352fb3 into master Jun 9, 2022
@davidgoli davidgoli deleted the fix-linting branch June 9, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants