Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selector based filtering? #947

Closed
merrywhether opened this issue May 18, 2017 · 3 comments
Closed

Selector based filtering? #947

merrywhether opened this issue May 18, 2017 · 3 comments

Comments

@merrywhether
Copy link

The transform function currently allows you to make optimizations on specific properties, but it would also be really helpful to be able to drop rules based on selectors in situations where you can't easily shape parts of the css that you're including in your app like including libraries, common-style-repos, etc. I'm not sure if this could be fit into the current transform callback as a third argument.

An example of this would be having a lot of selectors like .theme-light .button and .theme-light .card, and it'd be great to be able to test selectors and drop all selectors that include .theme-light in some way, leading to possible selector-less rule blocks that could then be omitted entirely from the resulting output.

@jakubpawlowicz
Copy link
Collaborator

Sure, we can have it. 👍

@jakubpawlowicz jakubpawlowicz modified the milestones: 3.4.27, 4.2.0 Jun 7, 2017
@jakubpawlowicz
Copy link
Collaborator

Fixed in master & due in 4.2.0.

@merrywhether
Copy link
Author

Awesome! Looking forward to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants