Prevent unquoting on grid elements #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "grid" element to list of elements ignored by removeQuotes. This prevents required quotes from being removed from single column grids.
|
Hey @jakubpawlowicz, let me know if you'd like me to do anything else on this change. I'd love to get this merged so I can remove my local package version dependency. :) |
|
Sorry it took a moment, but I only had time to review it now. Let's merge it. |
|
No worries, thanks for the merge! |
jakubpawlowicz
pushed a commit
that referenced
this pull request
Jan 25, 2020
* Prevent unquoting on grid elements Add "grid" element to list of elements ignored by removeQuotes. This prevents required quotes from being removed from single column grids. * Update optimize.js
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "grid" element to list of elements ignored by removeQuotes.
This prevents required quotes from being removed from single column grids.
Fixes #1078