Add events to upgrade & blocking callbacks #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iflan
approved these changes
Sep 20, 2022
| if (blocking) db.addEventListener('versionchange', () => blocking()); | ||
| if (blocking) { | ||
| db.addEventListener('versionchange', (event) => | ||
| blocking(event.oldVersion, event.newVersion, event), |
There was a problem hiding this comment.
I can't comment on line 81, but it appears that the blocked event is the same as a versionchange event:
- https://developer.mozilla.org/en-US/docs/Web/API/IDBOpenDBRequest/blocked_event#event_type
- https://chromium.googlesource.com/chromium/blink/+/refs/heads/main/Source/modules/indexeddb/IDBOpenDBRequest.cpp#78
- https://github.com/mozilla/integration-mozilla-inbound/blob/0d01aa29ce350beca861f7d3b7b4df399b246ed0/dom/indexedDB/OpenDatabaseHelper.cpp#L1524
You may want to do the same thing you do here up there. (I verified that close is a "simple event", so it has no extra properties.)
There was a problem hiding this comment.
Good catch! Typescript types it as a simple event, so I missed it.
There was a problem hiding this comment.
|
Published as 7.1.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.