Fix Release Perms #4098
Merged
Fix Release Perms #4098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <number101010@gmail.com>
fix ci-release.yml perms
Signed-off-by: Joe Elliott <number101010@gmail.com>
yurishkuro
approved these changes
Dec 8, 2022
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this pull request
Feb 22, 2023
This correctly sets the `contents` permission to `write`. This allowed CI on my fork to move past the "Upload Binaries" step. This fixes the change here: jaegertracing#4097 Signed-off-by: Joe Elliott <number101010@gmail.com>
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this pull request
Mar 5, 2023
This correctly sets the `contents` permission to `write`. This allowed CI on my fork to move past the "Upload Binaries" step. This fixes the change here: jaegertracing#4097 Signed-off-by: Joe Elliott <number101010@gmail.com> Signed-off-by: shubbham1215 <sawaikershubham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This correctly sets the
contentspermission towrite. This allowed CI on my fork to move past the "Upload Binaries" step. This fixes the change here: #4097