Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in ci-release.yml #4094

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Conversation

joe-elliott
Copy link
Member

Release of 1.40.0 is blocked b/c ci is failing with:

Invalid workflow file: .github/workflows/ci-release.yml#L12
The workflow is not valid. .github/workflows/ci-release.yml (Line: 12, Col: 3): Unexpected value 'content'

Reviewing docs it seems this node should be called contents.

Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott joe-elliott requested a review from a team as a code owner December 8, 2022 15:40
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 97.16% // Head: 97.17% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ebb88b9) compared to base (f6272e4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4094   +/-   ##
=======================================
  Coverage   97.16%   97.17%           
=======================================
  Files         295      295           
  Lines       17413    17413           
=======================================
+ Hits        16920    16921    +1     
+ Misses        397      396    -1     
  Partials       96       96           
Flag Coverage Δ
unittests 97.17% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugin/storage/integration/integration.go 76.33% <0.00%> (+0.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro yurishkuro merged commit 00e8fde into jaegertracing:main Dec 8, 2022
shubbham1215 pushed a commit to shubbham1215/jaeger that referenced this pull request Feb 22, 2023
Release of 1.40.0 is blocked b/c ci is failing with:

```
Invalid workflow file: .github/workflows/ci-release.yml#L12
The workflow is not valid. .github/workflows/ci-release.yml (Line: 12, Col: 3): Unexpected value 'content'
```

Reviewing docs it seems this node should be called `contents`.

Signed-off-by: Joe Elliott <number101010@gmail.com>
shubbham1215 pushed a commit to shubbham1215/jaeger that referenced this pull request Mar 5, 2023
Release of 1.40.0 is blocked b/c ci is failing with:

```
Invalid workflow file: .github/workflows/ci-release.yml#L12
The workflow is not valid. .github/workflows/ci-release.yml (Line: 12, Col: 3): Unexpected value 'content'
```

Reviewing docs it seems this node should be called `contents`.

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: shubbham1215 <sawaikershubham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants