Move Cassandra version check to docker.sh #4087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportBase: 97.16% // Head: 97.17% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4087 +/- ##
=======================================
Coverage 97.16% 97.17%
=======================================
Files 295 295
Lines 17413 17413
=======================================
+ Hits 16920 16921 +1
+ Misses 397 396 -1
Partials 96 96
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
albertteoh
reviewed
Dec 7, 2022
Comment on lines
19
to
23
| if [ -z "$PASSWORD" ]; then | ||
| CQLSH_CMD="${CQLSH} ${CQLSH_SSL} ${CQLSH_HOST} ${CQLSH_PORT}" | ||
| else | ||
| CQLSH_CMD="${CQLSH} ${CQLSH_SSL} ${CQLSH_HOST} ${CQLSH_PORT} -u ${USER} -p ${PASSWORD}" | ||
| fi |
There was a problem hiding this comment.
nit suggestion:
CQLSH_CMD="${CQLSH} ${CQLSH_SSL} ${CQLSH_HOST} ${CQLSH_PORT}"
if [ -n "$PASSWORD" ]; then
CQLSH_CMD="${CQLSH_CMD} -u ${USER} -p ${PASSWORD}"
fi
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this pull request
Feb 22, 2023
Alternative solution, closes jaegertracing#4056 This keeps the create.sh script simpler and not aware of cqlsh. Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Albert <26584478+albertteoh@users.noreply.github.com>
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this pull request
Mar 5, 2023
Alternative solution, closes jaegertracing#4056 This keeps the create.sh script simpler and not aware of cqlsh. Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Albert <26584478+albertteoh@users.noreply.github.com> Signed-off-by: shubbham1215 <sawaikershubham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative solution, closes #4056
This keeps the create.sh script simpler and not aware of cqlsh.