Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in filename #3837

Merged
merged 1 commit into from Aug 1, 2022
Merged

fix: typo in filename #3837

merged 1 commit into from Aug 1, 2022

Conversation

frzifus
Copy link
Member

@frzifus frzifus commented Aug 1, 2022

Short description of the changes

  • fix typo in filename

@frzifus
fix: typo in filename
991a3a8 
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
@frzifus frzifus requested a review from a team as a code owner August 1, 2022 16:17
@frzifus frzifus requested a review from yurishkuro August 1, 2022 16:17
@frzifus frzifus changed the title fix: type in filename fix: typo in filename Aug 1, 2022
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #3837 (991a3a8) into main (97feed9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3837   +/-   ##
=======================================
  Coverage   97.58%   97.58%           
=======================================
  Files         291      291           
  Lines       16962    16962           
=======================================
  Hits        16552    16552           
  Misses        323      323           
  Partials       87       87
Impacted Files Coverage Δ
cmd/collector/app/sampling/grpc_handler.go 100.00% <ø> (ø)
pkg/tenancy/flags.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aa2ae7...991a3a8. Read the comment docs.

yurishkuro
yurishkuro approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks

@yurishkuro yurishkuro merged commit 4d62874 into jaegertracing:main Aug 1, 2022
@frzifus frzifus deleted the fix/file_name branch August 1, 2022 17:11
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Aug 8, 2022
@frzifus @albertteoh
fix: typo in filename (jaegertracing#3837)
3e5c6c0 
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frzifus @yurishkuro