Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type mismatch in RateLimitingSamplingStrategy #43

Open
Falco20019 opened this issue Mar 6, 2018 · 1 comment
Open

Type mismatch in RateLimitingSamplingStrategy #43

Falco20019 opened this issue Mar 6, 2018 · 1 comment

Comments

@Falco20019
Copy link
Contributor

According to the sampling.thrift spec, the maxTracesPerSecond field should be an short value. The Java implementation uses a double value in it's ratelimiting_sampling.json and also in it's implementation.

I assume the thrift file is out of date and double is the correct type?
@Falco20019 Falco20019 mentioned this issue Mar 6, 2018
Closed
@black-adder
Copy link
Contributor

Sorry for taking so long to respond to this. Ideally maxTracesPerSecond should be double. All the rate limiting samplers in the clients for every language can handle double maxTracesPerSecond. When we move over to using protobuf to define our idl, we can address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@black-adder @Falco20019