Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Log errors that occur during ThriftSender's flush #728

Closed
pschichtel opened this issue Jul 30, 2020 · 7 comments
Closed

Log errors that occur during ThriftSender's flush #728

pschichtel opened this issue Jul 30, 2020 · 7 comments

Comments

@pschichtel
Copy link
Contributor

This is a followup issue to #726 / #369.

Currently both the HttpSender and (once #726 is merged) the UdpSender can fail on every flush() operation while the jaeger agent is not available.

The suggested improvement is to log just the first exception and then log once it works again. That way all the necessary/useful information is logged, but the log is not flooded with redundant errors.

@pschichtel
Copy link
Contributor Author

@jpkrohling From looking at the call stacks I assume that either RemoteReporter.FlushCommand#execute() or RemoteReporter.QueueProcessor#run() would be the right place to handle the error logging, right?

@pschichtel pschichtel changed the title Reduce log spam due to repeatedly failing ThriftSenders Log errors that occur during ThriftSender's flush Jul 30, 2020
@jpkrohling
Copy link
Collaborator

I believe so. We are already doing some exception handling at QueueProcessor#run and recording a metric in case it fails, so, that would be my preference.

@pschichtel
Copy link
Contributor Author

That's what I implemented in #729

@pschichtel
Copy link
Contributor Author

Is there any plan for an upcoming release that will contain these changes?

@pavolloffay
Copy link
Member

I can cut a patch release today

@pschichtel
Copy link
Contributor Author

Thanks!

@pavolloffay
Copy link
Member

The artifact should be available in the central

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants