Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Sampler tags are missing in root span generated from startSpan #611

Open
ChenX1993 opened this issue Dec 20, 2022 · 0 comments · May be fixed by #612
Open

[Bug]: Sampler tags are missing in root span generated from startSpan #611

ChenX1993 opened this issue Dec 20, 2022 · 0 comments · May be fixed by #612
Labels

Comments

@ChenX1993
Copy link

What happened?

The sampler tags (sampler.type & sampler.param) are missing in generated root span when additional tags option is provided in startSpan.

Steps to reproduce

  1. call tracer.StartSpan with tag option that has more than 2 key-value pairs.
t := opentracing.Tags{
"testTag1": "test tag 1",
"testTag2": "test tag 2",
"testTag3": "test tag 3",
}
sp := tracer.StartSpan("operation _name", t)
ss := sp.(*Span)

Expected behavior

The span should have expected sampler.type & sampler.param tags.

Relevant log output

No response

Screenshot

No response

Additional context

No response

Jaeger backend version

No response

SDK

No response

Pipeline

No response

Stogage backend

No response

Operating system

No response

Deployment model

No response

Deployment configs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant