Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample logger #609

Closed
wants to merge 2 commits into from
Closed

Sample logger #609

wants to merge 2 commits into from

Conversation

tttoad
Copy link

@tttoad tttoad commented Apr 22, 2022

Resolves #608

Inject logger when calling NewSampler method

@tttoad tttoad requested a review from a team as a code owner April 22, 2022 10:04
@tttoad tttoad requested review from joe-elliott and removed request for a team April 22, 2022 10:04
@yurishkuro
Copy link
Member

not accepting PRs

@yurishkuro yurishkuro closed this Sep 13, 2022
@tttoad tttoad deleted the sample_logger branch September 14, 2022 03:11
@ChenX1993 ChenX1993 mentioned this pull request Dec 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sampler logger is NullLogger
2 participants
@tttoad @yurishkuro