Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sampler logger is NullLogger #608

Open
tttoad opened this issue Apr 20, 2022 · 0 comments
Open

sampler logger is NullLogger #608

tttoad opened this issue Apr 20, 2022 · 0 comments
Labels

Comments

@tttoad
Copy link

tttoad commented Apr 20, 2022

Sampler initialization without logger injection.

func (sc *SamplerConfig) NewSampler(
	serviceName string,
	metrics *jaeger.Metrics,
) 

should be change to

func (sc *SamplerConfig) NewSampler(
	serviceName string,
	metrics *jaeger.Metrics,
	logger jaeger.Logger
) 

like

func (rc *ReporterConfig) NewReporter(
	serviceName string,
	metrics *jaeger.Metrics,
	logger jaeger.Logger,
) (jaeger.Reporter, error) {
@tttoad tttoad added the bug label Apr 20, 2022
@tttoad tttoad mentioned this issue Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant