Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename JAEGER_SAMPLER_MANAGER_HOST_PORT to JAEGER_SAMPLING_ENDPOINT #124

Open
2 tasks
jpkrohling opened this issue Aug 20, 2018 · 3 comments
Open
2 tasks

Comments

@jpkrohling
Copy link
Contributor

For each of the following linked tasks, change the documentation to include them. Add also a deprecation note on the description for the old name:

@Anisha-28
Copy link

Hi @jpkrohling if the issue is still open .. can i work on this issue .. and also can i get some clarity on this too

@jpkrohling
Copy link
Contributor Author

This issue is still open! At this point, this is what needs to be done:

  • check Converge on JAEGER_SAMPLING_ENDPOINT env variable for client's sampling jaeger#1849 to determine which clients are using which end vars. Looks like Java is still on JAEGER_SAMPLER_MANAGER_HOST_PORT, but other languages might be using JAEGER_SAMPLING_ENDPOINT already.
  • update the documentation to show the two env vars, and which clients support which
  • alongside with JAEGER_SAMPLER_MANAGER_HOST_PORT, mention that future versions of the clients might use the new JAEGER_SAMPLING_ENDPOINT instead

@jpkrohling jpkrohling changed the title Rename JAEGER_SAMPLER_MANAGER_HOST_PORT to JAEGER_CONFIG_MGR_HOST_PORT Rename JAEGER_SAMPLER_MANAGER_HOST_PORT to `JAEGER_SAMPLING_ENDPOINT Oct 9, 2020
@jpkrohling jpkrohling changed the title Rename JAEGER_SAMPLER_MANAGER_HOST_PORT to `JAEGER_SAMPLING_ENDPOINT Rename JAEGER_SAMPLER_MANAGER_HOST_PORT to JAEGER_SAMPLING_ENDPOINT Oct 9, 2020
@yurishkuro
Copy link
Member

Bonus: fix remaining clients to use the single env var consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants