Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE in StringSwitchEcjFilter #944

Merged
merged 4 commits into from Sep 22, 2019
Merged

Fix NPE in StringSwitchEcjFilter #944

merged 4 commits into from Sep 22, 2019

Conversation

Godin
Copy link
Member

@Godin Godin commented Sep 21, 2019

Following bytecode

         0: aload_1
         1: astore_2
         2: invokevirtual #121                // Method java/lang/String.hashCode:()I
         5: lookupswitch  { // 0
                 default: 17
            }
        17:

will cause NPE in StringSwitchEcjFilter.

@Godin Godin mentioned this pull request Sep 21, 2019
Closed
@Godin Godin self-assigned this Sep 21, 2019
@Godin Godin added this to Implementation in Current work items via automation Sep 21, 2019
@Godin Godin added this to the 0.8.5 milestone Sep 21, 2019
@Godin Godin added this to To Do in Filtering via automation Sep 21, 2019
@Godin Godin marked this pull request as ready for review September 22, 2019 13:44
@Godin Godin requested a review from marchof September 22, 2019 13:44
@Godin Godin moved this from Implementation to Review in Current work items Sep 22, 2019
@marchof marchof merged commit 18f571a into master Sep 22, 2019
Filtering automation moved this from To Do to Done Sep 22, 2019
Current work items automation moved this from Review to Done Sep 22, 2019
@marchof marchof deleted the fix_NPE_in_StringSwitchEcjFilter branch September 22, 2019 19:44
@jacoco jacoco locked as resolved and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marchof marchof marchof approved these changes

Assignees

@Godin Godin

Labels
component: core.filters type: bug 🐛 Something isn't working
Projects
Current work items
  
Done
Filtering
  
Done
Milestone
0.8.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Godin @marchof