Check whether source reference actually is a file #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marchof I'm wondering if this deserves changelog entry? 😉 |
|
@Godin Sure. Done |
A corner case has been reported where the source reference points to an folder. Instead of ignoring such a reference (as we do for missing files) in this case the report generation process fails. This fix checks that the source reference actually points to a file.
marchof
force-pushed
the
ensure-source-reference-is-file
branch
from
b8e6b97
to
89a1581
Compare
Godin
approved these changes
Sep 21, 2019
|
@marchof thanks! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A corner case has been reported where the source reference points to an folder. Instead of ignoring such a reference (as we do for missing files) in this case the report generation process fails. This fix checks that the source reference actually points to a file.
The issue war reported on the mailing list: https://groups.google.com/forum/?fromgroups=#!topic/jacoco/cx9sTR3KMr4