Remove instrument(ClassReader) and analyzeClass(ClassReader)

[Godin]

There are several problems with methods Instrumenter.instrument(ClassReader) and Analyzer.analyzeClass(ClassReader) :

• addition in JaCoCo of experimental support of new bytecode version, which is not yet supported by ASM, does not apply to these methods unlike other methods in Instrumenter and Analyzer

• their implementations use
  field org.objectweb.asm.ClassReader.b which was marked as deprecated in ASM 7.1

• they don't work in case when field ClassReader.b contains more than just bytes of one class (see ClassReader(byte[] classFileBuffer, int classFileOffset, int classFileLength)) and seems that there is no easy way to fix this

So I think that we have only two options:

1. mark them as deprecated and remove later
2. remove them

@marchof WDYT?

[marchof]

@Godin Good point -> Remove

[Godin]

For fun and future readers of this thread:

• to read bytes of class from ClassReader one can use ClassReader.readByte(int offset)
• to obtain classFileOffset one can use ClassReader.getItem(int constantPoolEntryIndex), i.e. classFileOffset = getItem(1) - 11
• however to determine classFileLength (which is even not used) one need logic to skip bytes of fields, methods and attributes