Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KotlinCoroutineFilter for Kotlin 1.3.30 #849

Merged
merged 3 commits into from Mar 4, 2019
Merged

Conversation

Godin
Copy link
Member

@Godin Godin commented Mar 1, 2019

During attempt to test resolution of KT-28453 (#791) in Kotlin 1.3.30 EAP

--- a/org.jacoco.core.test.validation.kotlin/pom.xml
+++ b/org.jacoco.core.test.validation.kotlin/pom.xml
@@ -28,2 +28,2 @@
-    <kotlin.version>1.3.0</kotlin.version>
+    <kotlin.version>1.3.30-eap-11</kotlin.version>
   </properties>
@@ -47,3 +47,16 @@
   </dependencies>

+  <repositories>
+    <repository>
+      <id>kotlin-eap</id>
+      <url>https://dl.bintray.com/kotlin/kotlin-eap</url>
+    </repository>
+  </repositories>
+  <pluginRepositories>
+    <pluginRepository>
+      <id>kotlin-eap</id>
+      <url>https://dl.bintray.com/kotlin/kotlin-eap</url>
+    </pluginRepository>
+  </pluginRepositories>
+
   <build>

Thanks to our validation tests I discovered KT-28015 (JetBrains/kotlin@19d2262):

$ mvn clean verify -Denforcer.skip
...
Failed tests:   execute_assertions_in_comments(org.jacoco.core.test.validation.kotlin.KotlinCoroutineTest): Instructions (KotlinCoroutineTarget.kt:22) expected:<[EMPTY]> but was:<[PARTLY_COVERED]>

@Godin Godin self-assigned this Mar 1, 2019
@Godin Godin added this to To Do in Filtering via automation Mar 1, 2019
@Godin Godin added this to Candidates in Current work items via automation Mar 1, 2019
@Godin Godin moved this from Candidates to Implementation in Current work items Mar 1, 2019
@Godin Godin closed this Mar 1, 2019
Current work items automation moved this from Implementation to Done Mar 1, 2019
@Godin Godin reopened this Mar 1, 2019
@Godin Godin moved this from Done to Implementation in Current work items Mar 1, 2019
@Godin Godin added this to the 0.8.4 milestone Mar 1, 2019
@Godin Godin moved this from Implementation to Review in Current work items Mar 1, 2019
@Godin Godin requested a review from marchof March 1, 2019 17:47
@marchof marchof merged commit c30eb29 into master Mar 4, 2019
Filtering automation moved this from To Do to Done Mar 4, 2019
Current work items automation moved this from Review to Done Mar 4, 2019
@marchof marchof deleted the kotlin_coroutines branch March 4, 2019 22:01
@jacoco jacoco locked as resolved and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Filtering
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants