Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use condy for probes array in Java 11+ class files #845

Merged
merged 14 commits into from Mar 5, 2019
Merged

Use condy for probes array in Java 11+ class files #845

merged 14 commits into from Mar 5, 2019

Conversation

Godin
Copy link
Member

@Godin Godin commented Feb 15, 2019

Users often forget to ignore synthetic fields when using reflection and continue asking questions even if this is already described in our FAQ - here is some recent ones:

We can get rid of this field in Java 11+ class files by using condy (JEP 309).

Also I think that condy might be better in terms of performance than ClassFieldProbeArrayStrategy in following cases

  • cold non JITed code and I suppose that this is quite common case when running unit tests
  • when JIT fails to inline $jacocoInit

@Godin Godin self-assigned this Feb 15, 2019
@Godin Godin added this to Candidates in Current work items via automation Feb 15, 2019
@Godin Godin moved this from Candidates to Implementation in Current work items Feb 15, 2019
@Godin Godin moved this from Implementation to Review in Current work items Feb 16, 2019
@Godin Godin closed this Feb 16, 2019
Current work items automation moved this from Review to Done Feb 16, 2019
@Godin Godin reopened this Feb 16, 2019
@Godin Godin moved this from Done to Review in Current work items Feb 16, 2019
@Godin Godin requested a review from marchof February 16, 2019 00:33
@Godin Godin added this to the 0.8.4 milestone Feb 16, 2019
@Godin Godin changed the title Use condy for probes array in Java 11+ classes Use condy for probes array in Java 11+ class files Feb 16, 2019
marchof
marchof requested changes Mar 4, 2019
View reviewed changes
Copy link
Member

@marchof marchof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor cleanup in tests, see comments.

@marchof marchof merged commit 36b4e9c into master Mar 5, 2019
Current work items automation moved this from Review to Done Mar 5, 2019
@marchof marchof deleted the condy branch March 5, 2019 05:53
@jacoco jacoco locked as resolved and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marchof marchof marchof approved these changes

Assignees

@Godin Godin

Labels
component: core type: enhancement
Projects
Current work items
  
Done
Milestone
0.8.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Godin @marchof