Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update filter for Kotlin coroutines that restore state #803

Merged
merged 7 commits into from
Dec 26, 2018
Merged

Update filter for Kotlin coroutines that restore state #803

merged 7 commits into from
Dec 26, 2018

Conversation

Godin
Copy link
Member

@Godin Godin commented Dec 22, 2018

No description provided.

@Godin Godin added this to the 0.8.3 milestone Dec 22, 2018
@Godin Godin self-assigned this Dec 22, 2018
@Godin Godin added this to To Do in Filtering via automation Dec 22, 2018
@Godin Godin added this to Implementation in Current work items via automation Dec 22, 2018
@Godin Godin force-pushed the filter_kotlin_coroutines branch 2 times, most recently from 3db556f to 35a8ac1 Compare December 22, 2018 23:02
@Godin Godin moved this from Implementation to Review in Current work items Dec 22, 2018
@Godin Godin requested a review from marchof December 23, 2018 01:29
marchof
marchof requested changes Dec 23, 2018
View reviewed changes
Copy link
Member

@marchof marchof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Godin I have to admit that I'm impressed by your deep-dive into the Kotlin compiler 😃

Therefore only two format suggestions about code style.

org.jacoco.core/src/org/jacoco/core/internal/analysis/filter/KotlinCoroutineFilter.java Outdated Show resolved Hide resolved
org.jacoco.core/src/org/jacoco/core/internal/analysis/filter/AbstractMatcher.java Outdated Show resolved Hide resolved
@marchof marchof merged commit 3b8df21 into master Dec 26, 2018
Filtering automation moved this from To Do to Done Dec 26, 2018
Current work items automation moved this from Review to Done Dec 26, 2018
@marchof marchof deleted the filter_kotlin_coroutines branch December 26, 2018 06:43
@jacoco jacoco locked as resolved and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marchof marchof marchof approved these changes

Assignees

@Godin Godin

Labels
component: core.filters language: Kotlin type: enhancement
Projects
Current work items
  
Done
Filtering
  
Done
Milestone
0.8.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Godin @marchof