Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter for Kotlin "unsafe" cast operator #761

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Add filter for Kotlin "unsafe" cast operator #761

merged 1 commit into from
Oct 5, 2018

Conversation

Godin
Copy link
Member

@Godin Godin commented Oct 3, 2018

Fixes #754

@Godin Godin added this to the 0.8.3 milestone Oct 3, 2018
@Godin Godin self-assigned this Oct 3, 2018
@Godin Godin added this to To Do in Filtering via automation Oct 3, 2018
@Godin Godin added this to Implementation in Current work items via automation Oct 3, 2018
@Godin Godin force-pushed the filter_kotlin_unsafe_cast_operator branch from 76a634c to 7ee39b2 Compare October 3, 2018 09:41
@Godin Godin force-pushed the filter_kotlin_unsafe_cast_operator branch 5 times, most recently from 52a14ac to ca240c5 Compare October 3, 2018 19:59
@Godin Godin requested a review from marchof October 3, 2018 21:10
@Godin Godin moved this from Implementation to Review in Current work items Oct 3, 2018
marchof
marchof approved these changes Oct 4, 2018
View reviewed changes
Copy link
Member

@marchof marchof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I have one minor remark.

...jacoco.core/src/org/jacoco/core/internal/analysis/filter/KotlinUnsafeCastOperatorFilter.java Outdated Show resolved Hide resolved
@Godin Godin force-pushed the filter_kotlin_unsafe_cast_operator branch from ca240c5 to ad2ce04 Compare October 4, 2018 23:33
@Godin Godin merged commit 9c6bb33 into master Oct 5, 2018
Filtering automation moved this from To Do to Done Oct 5, 2018
Current work items automation moved this from Review to Done Oct 5, 2018
@Godin Godin deleted the filter_kotlin_unsafe_cast_operator branch October 5, 2018 00:09
@jacoco jacoco locked as resolved and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marchof marchof marchof approved these changes

Assignees

@Godin Godin

Labels
component: core.filters language: Kotlin type: enhancement
Projects
Current work items
  
Done
Filtering
  
Done
Milestone
0.8.3
Development

Successfully merging this pull request may close these issues.

Weird coverage behavior with Kotlin .trim()
2 participants
@Godin @marchof