Add filter for Kotlin when-expressions that list all cases of enum #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Godin
force-pushed
the
kotlin_when_enum
branch
from
6ca1df0
to
8b48e8d
Compare
Godin
commented
Aug 13, 2018
| final int sourceOpcode = j.source.getNode().getOpcode(); | ||
| if ((sourceOpcode == Opcodes.LOOKUPSWITCH | ||
| || sourceOpcode == Opcodes.TABLESWITCH) | ||
| && ignored.contains(target.getNode())) { |
There was a problem hiding this comment.
Better to make this explicit.
There was a problem hiding this comment.
It looks like we don't have unit tests in MethodAnalyzerTest which covers this?
There was a problem hiding this comment.
As was discussed by phone: this even should not be here - filter should play role during counting and should not change CFG construction.
There was a problem hiding this comment.
I believe that this can be replaced by API that is being developed in #735
Godin
force-pushed
the
kotlin_when_enum
branch
2 times, most recently
from
33633a9
to
77a8dac
Compare
Godin
force-pushed
the
kotlin_when_enum
branch
from
77a8dac
to
d623d15
Compare
|
@marchof rebased |
Godin
commented
Aug 17, 2018
| */ | ||
| public final class KotlinWhenSealedFilter implements IFilter { | ||
| public final class KotlinWhenFilter implements IFilter { |
There was a problem hiding this comment.
@marchof we'll have KotlinWhenStringFilter and KotlinWhenFilter, but I didn't managed to find better name
marchof
force-pushed
the
kotlin_when_enum
branch
from
d623d15
to
68e91e0
Compare
marchof
approved these changes
Aug 18, 2018
|
@Godin I rebased this PR. Can you please re-check before merge? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.