Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ASM to 6.2.1 #725

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Upgrade ASM to 6.2.1 #725

merged 1 commit into from
Aug 9, 2018

Conversation

Godin
Copy link
Member

@Godin Godin commented Aug 8, 2018

As usual classes of JDK 12 EA already compiled into new bytecode version 56, so that ModifiedSystemClassRuntime can't be used without downgrade-upgrade workaround or ASM upgrade.

To notice changes in javac 12 EA unrelated to bytecode version such as #669 or even regressions such as JDK-8180141, one currently need to exclude integration tests which use agent:

$ java -version
openjdk version "12-ea" 2019-03-19
OpenJDK Runtime Environment 19.3 (build 12-ea+5)
OpenJDK 64-Bit Server VM 19.3 (build 12-ea+5, mixed mode)

$ mvn -V -B -e clean verify -Dbytecode.version=11 \
    -Djacoco.skip \
    -pl \!org.jacoco.ant.test,\!jacoco-maven-plugin.test,\!org.jacoco.examples.test,\!org.jacoco.doc,\!jacoco

Fortunately ASM 6.2.1 among other bug fixes and small improvements ( https://asm.ow2.io/versions.html , https://gitlab.ow2.org/asm/asm/compare/ASM_6_2...ASM_6_2_1 ) contains https://gitlab.ow2.org/asm/asm/merge_requests/187 with following interesting comments:

Eric Bruneton: Are there new bytecode features in this version? [...]
Remi Forax: None i'm aware of, plan for 12 are only languages changes (at that point). [...]

So to test compiler one can simply do

$ mvn clean verify -Dbytecode.version=11 \
    -Dasm.version=6.2.1

I propose to upgrade ASM anyway and maybe later think about experimental support for Java 12 class files.

@Godin Godin added this to the 0.8.2 milestone Aug 8, 2018
@Godin Godin self-assigned this Aug 8, 2018
@Godin Godin requested a review from marchof August 8, 2018 23:03
@marchof marchof merged commit 7bc6a0c into master Aug 9, 2018
@marchof marchof deleted the asm_6_2_1 branch August 9, 2018 06:11
@jacoco jacoco locked as resolved and limited conversation to collaborators Oct 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants