Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As usual classes of JDK 12 EA already compiled into new bytecode version 56, so that
ModifiedSystemClassRuntime
can't be used without downgrade-upgrade workaround or ASM upgrade.To notice changes in javac 12 EA unrelated to bytecode version such as #669 or even regressions such as JDK-8180141, one currently need to exclude integration tests which use agent:
Fortunately ASM 6.2.1 among other bug fixes and small improvements ( https://asm.ow2.io/versions.html , https://gitlab.ow2.org/asm/asm/compare/ASM_6_2...ASM_6_2_1 ) contains https://gitlab.ow2.org/asm/asm/merge_requests/187 with following interesting comments:
So to test compiler one can simply do
I propose to upgrade ASM anyway and maybe later think about experimental support for Java 12 class files.