Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter for Kotlin when-expressions that list all cases of sealed class #721

Merged
merged 1 commit into from
Aug 7, 2018
Merged

Add filter for Kotlin when-expressions that list all cases of sealed class #721

merged 1 commit into from
Aug 7, 2018

Conversation

Godin
Copy link
Member

@Godin Godin commented Aug 6, 2018

Fixes #704

@Godin Godin force-pushed the kotlin_when_sealed branch 2 times, most recently from d96b223 to 87c7a07 Compare August 6, 2018 22:18
@Godin Godin added this to IN PROGRESS in Filtering Aug 6, 2018
@Godin Godin self-assigned this Aug 6, 2018
marchof
marchof reviewed Aug 7, 2018
View reviewed changes
...t.validation.kotlin/src/org/jacoco/core/test/validation/kotlin/KotlinWhenExpressionTest.java Outdated
*/
@Test
public void whenSealed() {
assertLine("whenSealed.when", ICounter.FULLY_COVERED, 0, 0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably in conflict with #722.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflict resolved.

@Godin Godin added this to the 0.8.2 milestone Aug 7, 2018
@Godin Godin merged commit 8208774 into master Aug 7, 2018
@Godin Godin deleted the kotlin_when_sealed branch August 7, 2018 10:23
@Godin Godin moved this from IN PROGRESS to DONE in Filtering Aug 7, 2018
@jacoco jacoco locked as resolved and limited conversation to collaborators Oct 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marchof marchof marchof approved these changes

Assignees

@Godin Godin

Labels
component: core.filters language: Kotlin type: enhancement
Projects
Filtering
  
Done
Milestone
0.8.2
Development

Successfully merging this pull request may close these issues.

[Kotlin] The last case in when for seal object is never show coverage without already test
2 participants
@Godin @marchof