Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental support for Java 11 class files #719

Merged
merged 1 commit into from
Aug 6, 2018
Merged

Add experimental support for Java 11 class files #719

merged 1 commit into from
Aug 6, 2018

Conversation

Godin
Copy link
Member

@Godin Godin commented Aug 3, 2018

No description provided.

@marchof
Copy link
Member

marchof commented Aug 5, 2018

@Godin Is there a reason that we use native ASM support for Java 11 but still use the BytecodeVersion trick for Java 10?

@marchof
Copy link
Member

marchof commented Aug 5, 2018

@Godin I found two more places where the new Java version should be added:

  • InstrSupportTest.needFrames_should_return_true_for_versions_greater_than_or_equal_to_1_6()
  • ClassFileVersionsTest

@Godin
Copy link
Member Author

Godin commented Aug 5, 2018

@marchof updated InstrSupportTest and ClassFileVersionsTest. IMO we should find a way to reduce number of places that require non functional mechanical update.

Cleanup from V10 is unrelated to Java 11, so will do it separately.

@marchof marchof merged commit 250e176 into master Aug 6, 2018
@marchof marchof deleted the java11 branch August 6, 2018 07:00
@marchof
Copy link
Member

marchof commented Aug 6, 2018

@Godin You're right about reducing numbers of places, where we encode class file versions. Maybe something like

int[] SUPPORTED_VERSIONS;

in BytecodeVersion could be a solution.

@Godin Godin mentioned this pull request Aug 11, 2018
@jacoco jacoco locked as resolved and limited conversation to collaborators Oct 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants