Filter out synthetic classes during generation of report #668
Conversation
Godin
force-pushed
the
issue-660
branch
2 times, most recently
from
6d42429
to
1cc417a
Compare
|
@marchof could you please have a look? I can pull down implementation into existing |
|
@Godin For now I think this can be hardcoded in |
|
@marchof in this case could you please approve and I will do squash and merge 😉 |
|
|
||
| import org.jacoco.core.analysis.ICounter; | ||
| import org.jacoco.core.test.filter.targets.EnumSwitch; | ||
| import org.jacoco.core.test.validation.JavaVersion; |
There was a problem hiding this comment.
@marchof unused import removed
| @Test | ||
| public void testCoverageResult() { | ||
| if (isJDKCompiler && JAVA_VERSION.isBefore("1.6")) { | ||
| assertLine("switch", ICounter.PARTLY_COVERED, 0, 2); |
There was a problem hiding this comment.
Should we leave a comment why this is the case?
| <h3>New Features</h3> | ||
| <ul> | ||
| <li>Synthetic classes are filtered out during generation of report | ||
| (GitHub <a href="https://github.com/jacoco/jacoco/issues/668">#668</a>).</li> |
There was a problem hiding this comment.
What is our rule here: Do we refer to the PR or to the issue?
There was a problem hiding this comment.
@marchof I prefer to refer to actual changes, so to PR, and was following this principle here and before.
Fixes #660