AssertFilter does not ignore the assert statement

[morganga]

Steps to reproduce

• JaCoCo version: 0.8.8.20220405071
• Operating system: Mac OS
• Tool integration: Maven
• Complete executable reproducer: https://github.com/morganga/jacoco-bug
• Steps:
  mvn clean install
  the build fails (100% coverage is required) and
  the target/site/jacoco/net.gcvs.jacoco/App.java.html report does not indicate full coverage of the assert statements.

Expected behaviour

coverage of assert statement is considered complete, line in coverage report is green.
Code coverage should be considered complete with or without assertions enabled.

Actual behaviour

assert statement contains two branches and "1 of 2 branches missed", line in coverage report is yellow.

Currently the only way to obtain full coverage of an assert statement is by running the tests twice in the same test suite, once with assertions enabled, and again with assertions disabled, so both branches of the assert statement enabled test are visited.

#324 raised the problem of only 50% branch coverage. The AssertFilter introduced in 0.8.8 reduced the problem from a "2 of 4 branches missed" to a "1 of 2 branches missed". This wasn't exactly the intension of the #324 issue, which suggested "They should not be treated as code instructions."

(In case of exceptions provide FULL STACKTRACE)

[morganga]

I've implemented a solution in a pull request: #1379
Please take a look at the pull request, which contains screenshots of the implemented solution and a very similar alternative solution.

[ice1000]

Cool!!!!!!!!!!!!!!!!!!!!!!

[ice1000]

Hi, I believe that you need to write some tests :) The maintainers told me they only accept fully tested code.

[morganga]

I'm not sure what else they want. I've modified the existing test expectations.
In the comment of the AssertTarget.java assert line, and in the unit test AssertFilterTest.java

[oers]

I can confirm the same problems with 0.8.8 and a reduced code coverage.

[barakugav]

would love to see progress on this issue