Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental support for Java 18 class files #1198

Merged
merged 4 commits into from Jun 14, 2021
Merged

Add experimental support for Java 18 class files #1198

merged 4 commits into from Jun 14, 2021

Conversation

Godin
Copy link
Member

@Godin Godin commented Jun 13, 2021

No description provided.

@Godin Godin added this to the 0.8.8 milestone Jun 13, 2021
@Godin Godin self-assigned this Jun 13, 2021
@Godin Godin added this to Implementation in Current work items via automation Jun 13, 2021
@marchof marchof mentioned this pull request Jun 13, 2021
@Godin Godin marked this pull request as ready for review June 13, 2021 16:44
@Godin Godin requested a review from marchof June 13, 2021 16:45
@Godin Godin moved this from Implementation to Candidates in Current work items Jun 13, 2021
@Godin Godin moved this from Candidates to Implementation in Current work items Jun 13, 2021
@Godin Godin moved this from Implementation to Review in Current work items Jun 13, 2021
@Godin
Copy link
Member Author

Godin commented Jun 13, 2021

@marchof FYI here is quote of Remi Forax regarding support of Java 18 in ASM - https://gitlab.ow2.org/asm/asm/-/merge_requests/323 :

No classfile format change are currently schedule for Java 18, the only change is to add a new version V18.

There are numerous changes/fixes scheduled for Java 18 https://openjdk.java.net/jeps/8267650 but none of them directly concern ASM (perhaps apart re-saying that ACC_SUPER and ACC_STRICT are dead flags)

@marchof
Copy link
Member

marchof commented Jun 14, 2021

Hi @Godin , thanks for preparing Java 18 support! Do we want to update org.jacoco.doc/docroot/doc/build.html for Java 17 and 18?

@Godin
Copy link
Member Author

Godin commented Jun 14, 2021

Do we want to update org.jacoco.doc/docroot/doc/build.html for Java 17 and 18?

@marchof we also have list of supported versions for example in FAQ, so previously I was updating all these places once we add "official" support i.e. after their GA release. Will you prefer to update them all now or just build.html or wait for GA release?

@marchof marchof merged commit d5c0a83 into master Jun 14, 2021
Current work items automation moved this from Review to Done Jun 14, 2021
@marchof marchof deleted the java18 branch June 14, 2021 09:34
@marchof
Copy link
Member

marchof commented Jun 14, 2021

Adding it later if ok for me too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants