Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kotlin to 1.5.0 #1181

Merged
merged 1 commit into from May 4, 2021
Merged

Upgrade Kotlin to 1.5.0 #1181

merged 1 commit into from May 4, 2021

Conversation

Godin
Copy link
Member

@Godin Godin commented May 3, 2021

No description provided.

@Godin Godin added this to the 0.8.7 milestone May 3, 2021
@Godin Godin self-assigned this May 3, 2021
@Godin Godin added this to Implementation in Current work items via automation May 3, 2021
@Godin Godin moved this from Implementation to Review in Current work items May 3, 2021
@Godin Godin requested a review from marchof May 3, 2021 15:46
@Godin Godin marked this pull request as ready for review May 3, 2021 15:46
@marchof
Copy link
Member

marchof commented May 4, 2021

@Godin Does the compilation target table in build.html still correctly reflect the correct versions for Kotlin? Looks like Kotlin supports a larger range. And I wonder why we stop by Java 7.

@Godin
Copy link
Member Author

Godin commented May 4, 2021

@marchof

Looks like Kotlin supports a larger range. And I wonder why we stop by Java 7.

This like #1181 (comment) is also historical - I think some time ago they didn't had such large range.

Does the compilation target table in build.html still correctly reflect the correct versions for Kotlin?

Table should show what will be generated when bytecode.version not specified depending on JDK version.
And should be generated bytecode.version when it specified.
So you're right - both pom.xml and build.html should be adjusted.

I added such cleanup to this PR few seconds ago. Where I also made specification of groovy.targetBytecode consistent with kotlin.compiler.jvmTarget - more explicit and so IMO more readable/understandable.

@Godin Godin force-pushed the kotlin_1_5 branch 2 times, most recently from 338fd93 to a28ffcd Compare May 4, 2021 10:35
@Godin
Copy link
Member Author

Godin commented May 4, 2021

@marchof Also Kotlin compiler doesn't support 1.7 and 17 😉

[INFO] --- kotlin-maven-plugin:1.5.0:compile (compile) @ org.jacoco.core.test.validation.kotlin ---
[ERROR] Unknown JVM target version: 1.7
Supported versions: 1.6, 1.8, 9, 10, 11, 12, 13, 14, 15, 16

and 1.6 is deprecated

[INFO] --- kotlin-maven-plugin:1.5.0:compile (compile) @ org.jacoco.core.test.validation.kotlin ---
[WARNING] JVM target 1.6 is deprecated and will be removed in a future release. Please migrate to JVM target 1.8 or above

@Godin Godin force-pushed the kotlin_1_5 branch 3 times, most recently from 3333dba to 62108ec Compare May 4, 2021 10:58
@marchof marchof merged commit b25ce53 into master May 4, 2021
Current work items automation moved this from Review to Done May 4, 2021
@marchof marchof deleted the kotlin_1_5 branch May 4, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants