Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add url to jacoco-maven-plugin #1169

Merged
merged 2 commits into from Apr 14, 2021
Merged

Add url to jacoco-maven-plugin #1169

merged 2 commits into from Apr 14, 2021

Conversation

jakobbraun
Copy link
Contributor

jacoco-maven-plugin does not define a project URL in the pom file. In that case, maven inherits the value of the parent pom and appends the artifact id (see maven documentation).
By that maven resolves the URL to http://jacoco-maven-plugin/, which does not exist.

This PR fixes that issue by adding an explicit URL to the project.

jacoco-maven-plugin does not define a project URL in the pom file. In that case, maven inherits the value of the parent pom and appends the artifact id (see maven documentation).
By that maven resolves the URL to http://jacoco-maven-plugin/, which does not exist.
@Godin
Copy link
Member

Godin commented Mar 24, 2021

@jakobbraun could you please clarify where this URL is visible by users?

@jakobbraun
Copy link
Contributor Author

@Godin sure.
In my case, it's visible using the Maven API. I'm using the maven API to generate a notice file that references all dependencies.
Accoring to the maven docs it's a "nice gesture for projects users, however, so that they know where the project lives."

@redcatbear
Copy link

Having this fix would be beneficial for us since we would love to have a correct list of project pages.
We want to properly acknowledge all OSS makers where we use their software as external dependencies. And part of that acknowledgement is to get the project URL right.

Please consider merging this PR.

@Godin Godin changed the title Added url to jacoco-maven-plugin Add url to jacoco-maven-plugin Apr 13, 2021
@Godin Godin merged commit 2eca2f2 into jacoco:master Apr 14, 2021
@Godin Godin added this to the 0.8.7 milestone Apr 14, 2021
@Godin Godin added this to Implementation in Current work items via automation Apr 14, 2021
@Godin Godin moved this from Implementation to Done in Current work items Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants