Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update filter for unsafe cast operator for Kotlin 1.4 #1143

Merged
merged 9 commits into from Jan 5, 2021
Merged

Update filter for unsafe cast operator for Kotlin 1.4 #1143

merged 9 commits into from Jan 5, 2021

Conversation

Godin
Copy link
Member

@Godin Godin commented Dec 18, 2020 •
edited

Fixes #1134

@Godin Godin added this to the 0.8.7 milestone Dec 18, 2020
@Godin Godin self-assigned this Dec 18, 2020
@Godin Godin added this to Implementation in Current work items via automation Dec 18, 2020
@Godin Godin mentioned this pull request Dec 18, 2020
Closed
@Godin Godin added this to To Do in Filtering via automation Dec 26, 2020
@Godin Godin moved this from To Do to In Progress in Filtering Dec 26, 2020
@Godin Godin marked this pull request as ready for review January 5, 2021 14:54
@Godin Godin moved this from Implementation to Review in Current work items Jan 5, 2021
@Godin
Copy link
Member Author

Godin commented Jan 5, 2021

@marchof could you please review?

Since for implementation of unsafe cast Kotlin compiler now uses generic NullPointerException I hardened filter to not run on non-Kotlin classes and to hopefully remove possibility of filtering hand-written code, i.e. so far can't imagine hand-written Kotlin code that compiles into dup instruction followed by null-check.

Merge of this PR will also allow further update of Kotlin to 1.4.20 in org.jacoco.core.test.validation.kotlin during resolution of #1126.

@marchof marchof merged commit e859274 into master Jan 5, 2021
Filtering automation moved this from In Progress to Done Jan 5, 2021
Current work items automation moved this from Review to Done Jan 5, 2021
@marchof marchof deleted the kotlin_1_4_unsafe_cast branch January 5, 2021 18:37
@Godin Godin mentioned this pull request Mar 24, 2021
Closed
@Godin Godin mentioned this pull request Apr 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchof marchof marchof approved these changes

@jcenturion18 jcenturion18 jcenturion18 approved these changes

Assignees

@Godin Godin

Labels
component: core.filters language: Kotlin type: enhancement
Projects
Current work items
  
Done
Filtering
  
Done
Milestone
0.8.7
3 participants
@Godin @marchof @jcenturion18