Fix validation test for Java 15 #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With second preview the constructors of records now get the same access modifier than the class (see JDK-8242479). For "record WithoutFields" this leads to an private empty default constructor which is filtered out by PrivateEmptyNoArgConstructorFilter. Removing private modifiers from records to have consistent results between first and second preview.
|
Build with latest JDK-15 build is green: https://pici.beachhub.io/#/jdk-jacoco/20200519-191453 |
Godin
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With second preview the constructors of records now get the same access
modifier than the class (see JDK-8242479).
For "record WithoutFields" this leads to an private empty default
constructor which is filtered out by PrivateEmptyNoArgConstructorFilter.
Removing private modifiers from records to have consistent results
between first and second preview.