Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual cleanup of JDK/compilation target table #1034

Merged
merged 2 commits into from Jul 1, 2020
Merged

Visual cleanup of JDK/compilation target table #1034

merged 2 commits into from Jul 1, 2020

Conversation

marchof
Copy link
Member

@marchof marchof commented Mar 29, 2020

While reviewing #1033 I had a hard time again to read the JDK/classfile matrix in our build documentation (source as well as rendered html). I propose rework the matrix:

  • Use default table style
  • Remove redundant classfile version
  • Repeat and shorten cells to archieve visual grid

* Use default table style
* Remove redundant classfile version
* Repeat and shorten cells to archieve visual grid
@marchof marchof added this to the 0.8.6 milestone Mar 29, 2020
@marchof marchof requested a review from Godin March 29, 2020 13:08
@marchof marchof self-assigned this Mar 29, 2020
@bmarwell
Copy link

bmarwell commented Jul 1, 2020

@marchof could you add two screenshots? Before and after? I think this will help getting this PR merged.
That's just a random tought, though. ;-)

@Godin Godin added this to Implementation in Current work items via automation Jul 1, 2020
@Godin Godin moved this from Implementation to Review in Current work items Jul 1, 2020
@Godin
Copy link
Member

Godin commented Jul 1, 2020

Before

before

After

after

@Godin Godin merged commit 6ceb019 into master Jul 1, 2020
Current work items automation moved this from Review to Done Jul 1, 2020
@Godin Godin deleted the build-table branch July 1, 2020 18:52
@marchof
Copy link
Member Author

marchof commented Jul 1, 2020

@Godin Thx!

@bmarwell
Copy link

bmarwell commented Jul 2, 2020

Thanks! I highlighted this, because I am really looking forward to 0.8.6: It enables default method coverage. This was one of four remaining issues/PRs for that particular milestone.
Thanks for merging! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants