Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve compression method when instrumenting zip entries #1018

Merged
merged 6 commits into from Feb 11, 2020
Merged

Preserve compression method when instrumenting zip entries #1018

merged 6 commits into from Feb 11, 2020

Conversation

marchof
Copy link
Member

@marchof marchof commented Feb 9, 2020

Fixes #1004

@marchof marchof added this to the 0.8.6 milestone Feb 9, 2020
@marchof marchof requested a review from Godin February 9, 2020 19:50
@marchof marchof self-assigned this Feb 9, 2020
@marchof marchof added this to Implementation in Current work items via automation Feb 9, 2020
Current work items automation moved this from Implementation to Review Feb 10, 2020
Godin
Godin requested changes Feb 10, 2020
View reviewed changes
org.jacoco.doc/docroot/doc/changes.html Outdated Show resolved Hide resolved
org.jacoco.core/src/org/jacoco/core/instr/Instrumenter.java Outdated Show resolved Hide resolved
marchof and others added 3 commits February 10, 2020 21:04
@marchof @Godin
Link to PR
8004c1e 
Co-Authored-By: Evgeny Mandrikov <138671+Godin@users.noreply.github.com>
@marchof
Use compression method directly
c51097e
@marchof
Extract CRC calculation for better readability
0aa409a
@Godin Godin mentioned this pull request Feb 11, 2020
Closed
@Godin Godin merged commit 23c2ca7 into master Feb 11, 2020
Current work items automation moved this from Review to Done Feb 11, 2020
@Godin Godin deleted the issue-1004 branch February 11, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Godin Godin Godin approved these changes

Assignees

@marchof marchof

Labels
None yet
Projects
Current work items
  
Done
Milestone
0.8.6
Development

Successfully merging this pull request may close these issues.

CLI instrument Uber JAR compresses nested JARs
2 participants
@marchof @Godin