module.parent deprecated in Node 14+

[DaveyJake]

Describe the bug
As of Node v14.6.0, module.parent is deprecated.

To Reproduce
Steps to reproduce the behavior:

1. Attempting to use the plugin in my gulpfile.babel.js produces the following error:

TypeError: Cannot read property 'filename' of undefined at at Object. (/path/to/node_modules/gulp-load-plugins/index.js:170:46)

Expected behavior
I expect my node environment to startup like it always has.

Desktop (please complete the following information):

• OS: MacOS Big Sur 11.5.2
• Browser: Google Chrome
• Version: 93.0.4577.63

Temporary Fix
I've removed the parentDir variable from index.js and placed the path.dirname(module.parent.filename) value inside the config variable on line 47. It now looks like this:

const config = options.config || findup('package.json', { cwd: path.dirname(module.parent.filename) });

I now initialize the plugin inside my gulpfile.babel.js like this:

import plugins from 'gulp-load-plugins';

const $ = plugins({ config: path.resolve( __dirname, 'package.json' ) });

[strarsis]

@jackfranklin:
+1, this is a blocker for all recent node versions! 😿

davTypeError: Cannot read property 'filename' of undefined

const parentDir = path.dirname(module.parent.filename);

module.parent: https://nodejs.org/api/modules.html#modules_module_parent
Deprecated since: v14.6.0, v12.19.0

[jameelmoses]

I’m on vacation right now, but I’ll take a look at this next week. In the meantime, happy to review a PR if you’re inclined.

[romanalesenkov1]

any updates on the issue?

[jameelmoses]

I'm unable to replicate this issue on Node 14.18. Can you provide a repo that I'm able to replicate please?

How are you trying to instantiate the plugin? Can you try const $ = require('gulp-load-plugins')();?

[daedam]

I encountered this problem today as well, while trying to convert my gulpfile to use ESM. I am using the following in gulpfile.mjs to instantiate the plugin:

import gulpLoadPlugins from 'gulp-load-plugins';
const $ = gulpLoadPlugins();

I am running Node.js 16.14.2.

[jameelmoses]

Happy to look into this if someone can create a repo with a reproducible issue. I'm using Node v16.14.0 right now with gulpfile.babel.js without issue.

[jameelmoses]

can you try this instead of the multi-line statement?

const $ = require('gulp-load-plugins')();

[daedam]

Happy to look into this if someone can create a repo with a reproducible issue. I'm using Node v16.14.0 right now with gulpfile.babel.js without issue.

I created this repo to demonstrate the situation with using Gulp as an ECMAScript module (ESM). The main branch demonstrates the error using ESM syntax with import ... from. The commonjs branch is the working version using CommonJS with require().

[SCPCOEXR]

Also dealing with the issue @daedam mentioned.
Error [ERR_REQUIRE_ESM]: require() of ES Module C:\project\node_modules\gulp-imagemin\index.js from C:\project\node_modules\gulp-load-plugins\index.js not supported.
Instead change the require of C:\project\node_modules\gulp-imagemin\index.js in C:\project\node_modules\gulp-load-plugins\index.js to a dynamic import() which is available in all CommonJS modules.

Using your suggestion @jameelmoses of:
const $ = require('gulp-load-plugins')();

In my gulpfile.babel.js:
function images() { return gulp.src('src/assets/img/**/*') .pipe($.if(PRODUCTION, $.imagemin([ $.imagemin.jpegtran({ progressive: true }), ]))) .pipe(gulp.dest(PATHS.dist + '/assets/img')); }

[jameelmoses]

This has been resolved in v2.0.8