Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types for .name field #58

Merged
merged 1 commit into from
Apr 3, 2021
Merged

Fix types for .name field #58

merged 1 commit into from
Apr 3, 2021

Conversation

leafac
Copy link
Contributor

@leafac leafac commented Apr 3, 2021 

> emailAddresses.parseOneAddress("me@leafac.com").name
null
> emailAddresses.parseOneAddress("me@leafac.com").parts.name
null

@leafac
Fix types for .name field
45e1fe4 
```javascript
> emailAddresses.parseOneAddress("me@leafac.com").name
null
> emailAddresses.parseOneAddress("me@leafac.com").parts.name
null
```
@jackbearheart
Copy link
Owner

@leafac Thank you!

@jackbearheart jackbearheart merged commit 5d98276 into jackbearheart:master Apr 3, 2021
@leafac
Copy link
Contributor Author

leafac commented Apr 4, 2021

Thank you for maintaining this project. It works great for my use case 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leafac @jackbearheart