Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comma in display name #54

Merged
merged 6 commits into from
Dec 1, 2020
Merged

Conversation

osm
Copy link
Contributor

@osm osm commented Nov 13, 2020

No description provided.

@jackbearheart
Copy link
Owner

Hey, thanks for the PR.

A goal of this project is to implement email address parsing as per the specs published in RFCs. The comment you edited isn't a line we wrote, but is the original spec from rfc 5322. Unless you know of another document that supersedes this and allows commas, we can't just edit that.

However, I understand that this exception might be useful to people. We could add it to this library if we hide it behind an option flag.

@osm
Copy link
Contributor Author

osm commented Nov 15, 2020

Thanks for great feedback. I have now published a new commit that adds a new option called commaInDisplayName, which works in a similar way as the atInDisplayName-option.

@osm
Copy link
Contributor Author

osm commented Nov 21, 2020

Hi,

Just wanted to ping you @jackbearheart in case you missed the new commits in the PR.

@jackbearheart
Copy link
Owner

@osm Sorry for the delay. Thanks for this PR, it looks good!

@jackbearheart jackbearheart merged commit cbb3849 into jackbearheart:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants