New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use literal types to allow discriminated unions #45

Merged

jackbearheart merged 1 commit into jackbearheart:master from sciyoshi:patch-2

Sep 16, 2020

Contributor

sciyoshi commented Jun 2, 2019

See https://basarat.gitbooks.io/typescript/docs/types/discriminated-unions.html - this will allow TypeScript to narrow types when checking equality on the type field.


          Use literal types to allow discriminated unions

f063397

sciyoshi mentioned this pull request

How should I detect ParsedGroup? #41

Closed

Booligoosh commented Mar 8, 2020

@jackbearheart Would be awesome if you could merge this!

jackbearheart merged commit df10379 into jackbearheart:master

sciyoshi deleted the patch-2 branch

September 16, 2020 21:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment