Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rejectTLD option for input with no domain part produces error #33

Closed
pretender opened this issue Aug 23, 2017 · 1 comment
Closed

rejectTLD option for input with no domain part produces error #33

pretender opened this issue Aug 23, 2017 · 1 comment

Comments

@pretender
Copy link

Version 3.0.1

addrs = require("email-addresses")
addrs.parseAddressList({input: 'jack@'})
null

addrs.parseAddressList({input: 'jack@', rejectTLD: true})
TypeError: Cannot read property 'semantic' of null
at domainCheckTLD (email-addresses/lib/email-addresses.js:580:27)
jackbearheart added a commit that referenced this issue Aug 24, 2017
@jackbearheart
fix npe with rejectTLD option #33
6ac72d3
@jackbearheart
Copy link
Owner

Thank you for this bug report! This fix should do it. Let me know if you have any other problems.

@bkemper bkemper mentioned this issue Sep 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pretender @jackbearheart