Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Can't create pool size larger that 3 and can't get over a threshold speed. #249

Closed
rushi3691 opened this issue Jul 24, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@rushi3691
Copy link

rushi3691 commented Jul 24, 2023

Describe the bug
Whenever i give pool value greater than 3 like --pool 4 while downloading, it run for few seconds, then the program terminates itself. Also I've tried many ways to increase the speed. but its not getting above 3.5MBps (which is the highest I've recorded). But on telegram desktop i can get the maximum speed as of my wifi(which is about 9-10MBps).
Since the pool value is 3 by default, i guess, it gets 1MBps per connection. In my opinion to get maxium throughput, the number of pool connection must also be higher.

To Reproduce
tdl dl -f result.json --pool 4

Expected behavior
I should be able to get as much speed as desktop client.

I also want to contribute to this project. Let me know what I need to know and how can I help in any way.

@rushi3691 rushi3691 added the bug Something isn't working label Jul 24, 2023
@iyear
Copy link
Owner

iyear commented Jul 26, 2023

Excessively large thread pools or thread counts will force the connection to be closed by the Telegram server side. Download speed has always been a black box, especially when downloading across DCs is slow.

I don't know what the cause is at the moment.

@iyear
Copy link
Owner

iyear commented Jul 26, 2023

My guess is that the Telegram server treats the client's connection traits differently. That's why the official client tends to be faster across DCs. But I don't know exactly why.

Contributions are also very welcome. Documentation, code, use cases, uploads to other package management tools are all fine.

@roskyz
Copy link

roskyz commented Aug 3, 2023

Probably due to networking problem. No problems were found as regards direct connection.

  • Try to setup the --proxy parameter to access the telegram gateway through the proxy.
  • Start download tasks for a while, then manually restart the proxy server.
  • Problem occurred. In addition, the download speed could drop randomly compared with direct connection.

FYI: gotd/td#1030

@iyear
Copy link
Owner

iyear commented Nov 21, 2023

Please upgrade to v0.13.0 and feel free to reopen the issue if you have any questions.

@iyear iyear closed this as completed Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants