Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ci build #25

Merged
merged 3 commits into from Apr 26, 2021
Merged

Improve ci build #25

merged 3 commits into from Apr 26, 2021

Conversation

kaklakariada
Copy link
Contributor

@kaklakariada kaklakariada commented Apr 25, 2021 •
edited

  • Speedup build by caching sonar packages
  • Don't fail build for pull requests from forks
    • Run sonar analysis only when SONAR_TOKEN is available
    • Run test result report step only when GITHUB_TOKEN has write permissions

@kaklakariada kaklakariada self-assigned this Apr 25, 2021
@kaklakariada kaklakariada added the enhancement New feature or request label Apr 25, 2021
redcatbear
redcatbear approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@redcatbear redcatbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thanks a lot.
Approved.

@redcatbear redcatbear merged commit bedde31 into develop Apr 26, 2021
@redcatbear redcatbear deleted the improve-ci-build branch April 26, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redcatbear redcatbear redcatbear approved these changes

Assignees

@kaklakariada kaklakariada

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kaklakariada @redcatbear