#21: Delegate Security Manager #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvn license:update-file-header
feature/23-Delegate_Security_Manager Conflicts: README.md src/main/java/org/itsallcode/junit/sysextensions/ExitGuard.java src/main/java/org/itsallcode/junit/sysextensions/security/ExitGuardSecurityManager.java src/test/java/org/itsallcode/junit/sysextensions/TestSystemExit.java
redcatbear
changed the title
kaklakariada
approved these changes
Apr 24, 2021
|
|
||
| public ExitGuardSecurityManager(final SecurityManager delegate) | ||
| { | ||
| this.delegate = delegate; |
There was a problem hiding this comment.
Check if argument is null and use a default SecurityManager with empty methods. Then you can avoid the null checks when delegating.
There was a problem hiding this comment.
I thought about this, but I find the other option less invasive.
src/main/java/org/itsallcode/junit/sysextensions/security/ExitGuardSecurityManager.java
Show resolved
Hide resolved
.../java/org/itsallcode/junit/sysextensions/TestSystemExitReplacingExistingSecurityManager.java
Show resolved
Hide resolved
Co-authored-by: chπ <kaklakariada@chp1.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21.